feat: pre-electra support from attestation pool #6998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensi321
force-pushed
the
nc/attestation-api-v2
branch
from
c6e1cca
to
c9394c6
Compare
ensi321
force-pushed
the
nc/attestation-pool
branch
from
af660d5
to
97b089a
Compare
nflaig
reviewed
Aug 5, 2024
Base automatically changed from
nc/attestation-api-v2
to
electra-fork-rebasejul30
August 5, 2024 19:53
|
lgtm |
twoeths
reviewed
Aug 6, 2024
twoeths
reviewed
Aug 6, 2024
twoeths
reviewed
Aug 6, 2024
twoeths
reviewed
Aug 6, 2024
ensi321
force-pushed
the
nc/attestation-pool
branch
from
97b089a
to
99a85a8
Compare
nflaig
reviewed
Aug 6, 2024
packages/beacon-node/src/chain/opPools/aggregatedAttestationPool.ts
Outdated
Show resolved
Hide resolved
packages/beacon-node/src/chain/opPools/aggregatedAttestationPool.ts
Outdated
Show resolved
Hide resolved
g11tech
force-pushed
the
electra-fork-rebasejul30
branch
3 times, most recently
from
f83cbf3
to
72b8074
Compare
Co-authored-by: Nico Flaig <[email protected]>
Co-authored-by: Nico Flaig <[email protected]>
…ol.ts Co-authored-by: Nico Flaig <[email protected]>
* fix: getSeenAttDataKey apis * chore: use ForkName instead of ForkSeq
g11tech
force-pushed
the
nc/attestation-pool
branch
from
f0e83b6
to
4c81a0d
Compare
nflaig
reviewed
Aug 9, 2024
packages/beacon-node/src/chain/opPools/aggregatedAttestationPool.ts
Outdated
Show resolved
Hide resolved
packages/beacon-node/test/perf/chain/opPools/aggregatedAttestationPool.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Nico Flaig <[email protected]>
…ol.ts Co-authored-by: Nico Flaig <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## electra-fork-rebasejul30 #6998 +/- ##
===========================================================
Coverage ? 49.35%
===========================================================
Files ? 589
Lines ? 39186
Branches ? 2238
===========================================================
Hits ? 19342
Misses ? 19803
Partials ? 41 |
nflaig
reviewed
Aug 13, 2024
packages/beacon-node/src/chain/opPools/aggregatedAttestationPool.ts
Outdated
Show resolved
Hide resolved
packages/beacon-node/src/chain/opPools/aggregatedAttestationPool.ts
Outdated
Show resolved
Hide resolved
packages/beacon-node/src/chain/opPools/aggregatedAttestationPool.ts
Outdated
Show resolved
Hide resolved
…ol.ts Co-authored-by: Nico Flaig <[email protected]>
|
looks like last round of review to be addressed, then we can merge this |
g11tech
pushed a commit
that referenced
this pull request
Aug 23, 2024
* Initial commit * Update packages/beacon-node/src/chain/chain.ts Co-authored-by: Nico Flaig <[email protected]> * Update packages/beacon-node/src/api/impl/validator/index.ts Co-authored-by: Nico Flaig <[email protected]> * Update packages/beacon-node/src/chain/opPools/aggregatedAttestationPool.ts Co-authored-by: Nico Flaig <[email protected]> * address comment * Add unit test for attestation pool * fix: getSeenAttDataKey apis (#7009) * fix: getSeenAttDataKey apis * chore: use ForkName instead of ForkSeq * Update packages/beacon-node/src/util/sszBytes.ts Co-authored-by: Nico Flaig <[email protected]> * Update packages/beacon-node/src/chain/opPools/aggregatedAttestationPool.ts Co-authored-by: Nico Flaig <[email protected]> * address comment * Update error message * Update packages/beacon-node/src/chain/opPools/aggregatedAttestationPool.ts Co-authored-by: Nico Flaig <[email protected]> * address comment * Move determining post-electra fork out of loops --------- Co-authored-by: Nico Flaig <[email protected]> Co-authored-by: twoeths <[email protected]>
g11tech
pushed a commit
that referenced
this pull request
Aug 27, 2024
* Initial commit * Update packages/beacon-node/src/chain/chain.ts Co-authored-by: Nico Flaig <[email protected]> * Update packages/beacon-node/src/api/impl/validator/index.ts Co-authored-by: Nico Flaig <[email protected]> * Update packages/beacon-node/src/chain/opPools/aggregatedAttestationPool.ts Co-authored-by: Nico Flaig <[email protected]> * address comment * Add unit test for attestation pool * fix: getSeenAttDataKey apis (#7009) * fix: getSeenAttDataKey apis * chore: use ForkName instead of ForkSeq * Update packages/beacon-node/src/util/sszBytes.ts Co-authored-by: Nico Flaig <[email protected]> * Update packages/beacon-node/src/chain/opPools/aggregatedAttestationPool.ts Co-authored-by: Nico Flaig <[email protected]> * address comment * Update error message * Update packages/beacon-node/src/chain/opPools/aggregatedAttestationPool.ts Co-authored-by: Nico Flaig <[email protected]> * address comment * Move determining post-electra fork out of loops --------- Co-authored-by: Nico Flaig <[email protected]> Co-authored-by: twoeths <[email protected]>
philknows
pushed a commit
that referenced
this pull request
Sep 3, 2024
* Initial commit * Update packages/beacon-node/src/chain/chain.ts Co-authored-by: Nico Flaig <[email protected]> * Update packages/beacon-node/src/api/impl/validator/index.ts Co-authored-by: Nico Flaig <[email protected]> * Update packages/beacon-node/src/chain/opPools/aggregatedAttestationPool.ts Co-authored-by: Nico Flaig <[email protected]> * address comment * Add unit test for attestation pool * fix: getSeenAttDataKey apis (#7009) * fix: getSeenAttDataKey apis * chore: use ForkName instead of ForkSeq * Update packages/beacon-node/src/util/sszBytes.ts Co-authored-by: Nico Flaig <[email protected]> * Update packages/beacon-node/src/chain/opPools/aggregatedAttestationPool.ts Co-authored-by: Nico Flaig <[email protected]> * address comment * Update error message * Update packages/beacon-node/src/chain/opPools/aggregatedAttestationPool.ts Co-authored-by: Nico Flaig <[email protected]> * address comment * Move determining post-electra fork out of loops --------- Co-authored-by: Nico Flaig <[email protected]> Co-authored-by: twoeths <[email protected]>
|
🎉 This PR is included in v1.22.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aggregateByIndexByRootBySlotis modified to allow null committee index to only handle pre-electra attestations. null committee index is not allowed post-electra attestationsbeacon_attestationin gossip queue is indexed by attestation data instead of attestation data + committee bits.